[Bug 26272] Improve acknowledging and nacking IQs

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Mar 3 15:38:50 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=26272

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-03-03 06:38:49 PST ---
Your misc branch looks fine.

Your ack-and-nak branch also looks fine apart from:

 * the two TODOs in the tests
 * I got a bit confused by 7882c658b7d5. If you could highlight that get/set
have exactly one child elements, result have zero or one child elements then
that'd make things clearer. The way the RFC says how an error SHOULD have one
and only one child element from the original IQ is confusing as I wondered how
it could ever be >1.

Seems fine otherwise.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list