[Bug 31376] TpFileTransferChannel : high level API for FT

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31376

--- Comment #4 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2011-03-03 16:29:18 PST ---
(In reply to comment #2)
> > gint64 *tp_ft_channel_get_date (TpFTChannel *self);
> 
> Maybe we could use a GDateTime instead?

GDateTimes require memory management (unreffing etc). Perhaps it's better to
return a gint64 and let the user create a GDateTime if it's useful to her? Or
we could have both accessors.

> > void tp_ft_channel_accept_async (TpFTChannel *self,
> >     guint64 offset,
> >     GFile *file,
> >     GCancellable *cancellable,
> >     GAsyncReadyCallback callback,
> >     gpointer user_data);
> 
> I'd swap the offset and file args.

> Do we really need a GCancellable? User can just close the channel to stop
> sending/receiving. And once the operation has been cancelled we can't do much
> with the channel anyway.

Agreed.

> When are these operations succeeding? As soon as the D-Bus call returns or
> when the sending/receiving is done?

I was wondering the same thing. Do these return once the FT is set up (in which
case you need to monitor the state) or once the transfer is complete (in which
case we don't need to expose the state, we can just return whatever we want in
the GError).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.