[Bug 28367] Add StreamTube interface support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28367

--- Comment #21 from Dario Freddi <drf54321 at gmail.com> 2011-03-06 07:05:05 PST ---
Hi Olli and thanks for the review. Just like I did with Andre's comments, I
addressed each point you brought to attention in a separate commit. I am
commenting what is worth commenting below:

(In reply to comment #19)
> channel-class-spec.h:
> 
>  186     static ChannelClassSpec outgoingStreamTube(const QVariantMap
> &additionalProperties = QVariantMap());
>  187     static ChannelClassSpec incomingStreamTube(const QVariantMap
> &additionalProperties = QVariantMap());
> 
> Add const QString &service = QString() as the first argument (and don't insert
> the key at all if the default value was passed, rather than inserting the empty
> QString).

Did that, although I am not really sure of the implementation, so I'd ask you
to review carefully this specific commit.

> Sorry for not noticing this earlier (by earlier I mean up to a year ago when I
> first looked at this!), but the same "not everything uses the Qt network
> classes" requirement holds here as well.

Indeed. I ended up removing all the logic for connecting to a QIODevice, and
changed the exposed methods in IncomingTubeChannel to reflect the ones in the
PendingOperation. And I also agree on not providing a way for building a
QIODevice, given how easy it is (the example was updated accordingly).

> Also I'd like to see RCCSpec and CapabilitiesBase methods for stream tubes.
> These are not essential though: I'd like to see this branch finally merged and
> not bitrotting further as a first priority, we can add the capability stuff in
> an another quick branch.

I agree with doing this after the merge, and I will take care of it.

P.S.: To both of you, would you also mind trying out the example and tell me if
it works for you?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.