[Bug 26272] Improve acknowledging and nacking IQs

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Mar 7 16:16:15 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=26272

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #7 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-03-07 07:16:12 PST ---
+  /* Send an illegal IQ with two child elements. We expect that
+   * wocky_porter_acknowledge_iq() should cope. */
+  iq = wocky_stanza_build (WOCKY_STANZA_TYPE_IQ,
+      WOCKY_STANZA_SUB_TYPE_GET, "juliet at example.com", "romeo at example.net",
+      '(', "sup-dawg", ')',
+      '(', "i-heard-you-like-stanzas", ')',
+      NULL);
+  expected_reply = wocky_stanza_build (
+      WOCKY_STANZA_TYPE_IQ, WOCKY_STANZA_SUB_TYPE_RESULT,
+      "romeo at example.net", "juliet at example.com",
+      '(', "sup-dawg",
+        '@', "lions", "tigers",
+      ')',
+      NULL);

Isn't this a bit of a poor test? If you reply with something other than a
'sup-dawg' child element, then the result IQ has two child elements, right?
It'd be cooler if this was more explicit.

Oh, no, I'm getting confused with error. Ignore that then.

LOOKS HOT.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list