[Bug 35321] Implement 3rd party message send/receive API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35321

--- Comment #6 from Olli Salli <ollisal at gmail.com> 2011-03-15 11:28:29 PDT ---
Yeah, put that way I agree with you on the method names actually. The long
versions are indeed clearer.

Umm, you now have the overloads twice for sendMessage() :) So clean that up,
please.

The MessageSent signal should include the Channel as well. The signal is
supposed to be emitted from Observing channels, not as a direct response to
sendMessage() we generate ourselves. In particular, this signal is useful when
somebody else than you sends a message to the contact you're messaging with.
The direct response to sending messages ourselves is finishing the PendingSend.

MessageParts are message parts, they're not specifications for message parts!
The "spec" I added in names for (Requestable)ChannelClassSpec means
"specification" as in "formal specification" - it's not applicable here, as the
message parts are data, not format specifications or such for data. For a name
which doesn't clash with the auto-generated MessagePart struct, how about
MessageContentPart? Or RichMessagePart, as that API would only be used for
various kinds of "rich messages"?

Otherwise looks good now.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.