[Bug 24653] Should implement ContactCapabilities

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=24653

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-03-18 01:51:34 PDT ---
(In reply to comment #3)
> +      const gchar *client_name = g_value_get_string (va->values + 0);
> +      const GPtrArray *filters = g_value_get_boxed (va->values + 1);
> +      const gchar * const * cap_tokens = g_value_get_boxed (va->values + 2);
> 
> I could suggest using tp_value_array_unpack here? I don't know how much clearer
> it would actually be.

I'd rather just keep it the same tbh as it'll be the same as gabble, not sure
how much of an argument that really is.. anyway, yeah, deal widdit.

> I'm tempted to say that the former block should be inside the latter — why
> would we want to publish updated caps if they haven't changed? I know this
> isn't a regression in your branch.

Yeah you're right, I've fixed this. See the latest patch on my branch then.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.