[Bug 34796] Implement ContactInfo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34796

--- Comment #13 from Will Thompson <will.thompson at collabora.co.uk> 2011-03-21 09:11:11 PDT ---
Review of attachment 44075:
 --> (https://bugs.freedesktop.org/review?bug=34796&attachment=44075)

Looks mostly good.

::: src/idle-contact-info.c
@@ +269,3 @@
+    g_value_array_prepend(norm_args, &value);
+
+     * caused by us, and we do not want to handle it.

These contortions make it look like _is_valid_response() should be changed to
take a TpHandle as the second argument, rather than having to fake up a
GValueArray which it just grabs the first element of.

@@ +274,3 @@
+    request = g_queue_peek_head(conn->contact_info_requests);
+
+     * To check this we map the value of the <server name> to a handle and see
if it matches the handle for which we had made the request.

The fact that the error is “no such server” is an IRC protocol oddity, and I
imagine this will confuse people reading dbus-monitor! Maybe the message could
be something like “User '%s' unknown; they may have disconnected”?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.