[Bug 34932] Use WockyMetaPorter

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34932

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-03-23 09:16:24 PDT ---
Your fixes to my first batch of comments look good, except:

(In reply to comment #2)
> (In reply to comment #1)
> > +          addresses = g_list_append (addresses, socket_address);
> > 
> > <http://en.wikipedia.org/wiki/Schlemiel_the_Painter's_algorithm>. Yeah, it's
> > not a big deal here, but this is one reason I like stack-allocated GQueues: you
> > can build GLists with repeated O(1) append. I guess this isn't new code though.
> 
> Yeah yeah, I've never been a fan of this and actually I'm not sure why. I guess
> perhaps because it feels like such an epic hack to get around the terrible data
> structure we're using. I guess we're doing worse things just by using GObject.
> 
> Fixed.

--. Repeated prepends followed by reverse is even worse than using a dumb O(n²)
algorithm.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.