[Bug 35410] Implement ServerTLSConnection.ReferenceIdentities in gabble

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35410

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-, one question

--- Comment #4 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-03-28 09:12:34 PDT ---
Looks good. Just one question really.

+  /* And secondly the an explicitly overridden server */
+  connect_server = NULL;
+  g_object_get (tp_base_channel_get_connection (TP_BASE_CHANNEL (self)),
+      "connect-server", &connect_server, "explicit-server", &explicit_server,
+      NULL);

Why do you set connect_server to NULL but not explicit_server? Am I missing
something.

Also, please have these on different lines so you have:

  "property-name", &location_to_store,
  "property-name", &location_to_store,

Also the comment English is a little broken.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.