[Bug 33911] Remove Loudmouth wrapper

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33911

--- Comment #3 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-05-02 08:53:20 PDT ---
- result = wocky_stanza_build_iq_result (stanza, NULL);
-
- wocky_porter_send (porter, result);
-
- g_object_unref (result);
+ wocky_porter_acknowledge_iq (porter, stanza, NULL);
return TRUE;
}
@@ -879,17 +874,19 @@ iq_privacy_list_push_cb (LmMessageHandler *handler,
!list_node)
return LM_HANDLER_RESULT_ALLOW_MORE_HANDLERS;
- result = lm_iq_message_make_result (message);
+ result = wocky_stanza_build_iq_result (message, NULL);
- wocky_porter_send (wocky_session_get_porter (conn->session), result);
+ if (result != NULL)
+ {
+ wocky_porter_send (wocky_session_get_porter (conn->session), result);
+ g_object_unref (result);
+ }

Why do you use acknowledge_iq in the first case, but build_iq_result and then
immediately send it in the second case?

(I've not reviewed your top patch removing GabbleXmppError yet because I saw it
and I tl;dr'd it for now.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.