[Bug 33911] Remove Loudmouth wrapper

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33911

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2011-05-03 05:18:33 PDT ---
(In reply to comment #4)
> (Why can't I copy paste spaces today I wonder?
> 
> +  if (vcard_error->domain == WOCKY_XMPP_ERROR)
> +    if (vcard_error->code == WOCKY_XMPP_ERROR_BAD_REQUEST ||
> +        vcard_error->code == WOCKY_XMPP_ERROR_NOT_ACCEPTABLE)
>        tp_error.code = TP_ERROR_INVALID_ARGUMENT;
> 
> Can't say I approve of this, but yeah it's not new code.

I guess it should probably use gabble_set_tp_error_from_wocky() but I didn't
really want to go down the road of changing everything to use this just yet.

>   DEBUG ("fetching location failed: %s", wocky_error->message);
> + /* FUUCK */
>   gabble_set_tp_error_from_wocky (wocky_error, &tp_error);
> 
> Hm?

Ahem. I don't know where that came from. Amended.

> 
> - GError *error = gabble_message_get_xmpp_error (reply);
> + GError *error = NULL;
> +
> + /* FIXME: did anything depend on getting errors outside core? */
> + wocky_stanza_extract_errors (reply, NULL, &error, NULL, NULL);
> 
> This is not a regression though, is it?

It might be: gabble_message_get_xmpp_error() parsed Jingle and SI errors as
well as just XMPP core errors. So I have just checked everything that uses the
request pipeline (whether directly or indirectly) and nothing was relying on
this.

Pushed a patch removing the FIXME!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.