[Bug 36844] Changes to non-parameters from storage backends may not get propagated to CMs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=36844

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-, minor

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-05-04 08:25:45 PDT ---
I can't help thinking that the whole account-storage API needs a redesign...
but this looks a reasonable approach to getting the desired side-effect of
changing a property.

One thing that's a bit wrong:

> + if (prop->setprop != NULL)
> + prop->setprop (self, prop->name, &value, NULL);
> +
> + /* now emit our own property changed signal directly */
>   mcd_account_changed_property (account, prop->name, &value);

The Set() implementation for every mutable property should be calling
mcd_account_changed_property already (e.g. for Nickname this is via
mcd_account_set_string_val).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.