[Bug 34796] Implement ContactInfo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34796

--- Comment #46 from Will Thompson <will.thompson at collabora.co.uk> 2011-05-06 04:26:35 PDT ---
Review of attachment 46377:
 --> (https://bugs.freedesktop.org/review?bug=34796&attachment=46377)

::: src/idle-contact-info.c
@@ +321,3 @@
+
+    /* msg == "is connecting from *@<hostname> <IP>" */
+    request = g_queue_peek_head(conn->contact_info_requests);

You need to check that there are actually more than three elements in the
string. Relying on the server not sending malformed data, and crashing if it
does, doesn't seem wise.

I think I would check whether the string actually has the expected prefix; if
it does, strsplit the remainder of the string and put that in the contact info
field; if it does not, either just include the whole string verbatim or ignore
it?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.