[Bug 23151] Chan.I. Room — properties of chatrooms and chatroom-like constructs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=23151

--- Comment #33 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-05-09 08:28:40 PDT ---
(In reply to comment #31)
> What's the point of the Room_Subject_Present flag? Surely if the Subject
> interface is implemented, then the channel has a subject; and if not, it
> doesn't? Is this a remnant of Subject being part of Room?

Yes.

> I think Can_Set's docstring should be clarified to say that it refers to having
> permission to change the subject; and that if the implementation isn't sure, it
> SHOULD be set, citing the inadequacies of XEP-0045 in the rationale. I think
> the name is fine, the description is just misleading.

Done.

> If we got rid of the Present flag, then I think the change notification for the
> flags could be a separate signal. (Actually I think we could use
> DBus.Properties.PropertyChanged for this interface.)

Done.

> I can see an argument for having the ssx bit of the subject be a single
> property, though it might be clearer to have them be separate properties;

Done.

> but I feel like the flags should be separate. (Or we could even have a
> CanSetSubject: b property. Adding more properties isn't more expensive
> than adding new enum members.)

Done.

> The preamble should not say “by Room channels”, it should say “by channels 
> with the <tp:dbus-ref...>Room</> interface”.

Done.

> > Clients SHOULD NOT assume success if no errors are raised by calling
> > this method, but instead should listen to the SubjectChanged signal
> > for change notification.
> 
> Why? I think the method should not return until it's either succeeded or
> failed; but clients SHOULD monitor the SubjectChanged signal in case the topic
> was modified/truncated by the server or whatever.

Okay, done.

> RoomName and Server should grow the immutable and requestable attributes.

Done.

(In reply to comment #32)
> Oh maybe also mention in the preambles that both interfaces could apply to (eg)
> calls.

Done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.