[Bug 36490] TpBaseClient: need a way to tell we are handling a channel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=36490

--- Comment #5 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-05-10 00:28:35 PDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > Implemented in
> > http://cgit.collabora.co.uk/git/user/cassidy/telepathy-glib/log/?h=claim-handle-36490
> 
> The commit message "add tp_channel_dispatch_operation_claim_and_handle_async()
> (fdo #36490)" doesn't really work anymore.

Good catch, I ammended the commit.

> in your test case, in claim_with_cb:
> 
> + test->wait--;
> + if (test->wait <= 0)
> + g_main_loop_quit (test->mainloop);
> 
> But I don't see you incrementing test->wait?

Right, it's only used when waiting for more than one event (as it's init to
0); I always use test->wait that way in all my tests.
But I can explicitely set it to 1 if you prefer

> + g_simple_async_result_set_op_res_gpointer (result, g_object_ref (client),
> + g_object_unref);
> 
> makes me lol, but oh well!

It's much easier than allocating a context struct, etc (thanks C...).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.