[Bug 37079] tp_base_connection_change_status can have a side-effect before hitting a return_if_fail

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37079

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-05-10 11:13:43 PDT ---
Created an attachment (id=46558)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46558
 Review: https://bugs.freedesktop.org/review?bug=37079&attachment=46558

tp_base_connection_change_status: delay side-effects until  all preconditions
are checked

If the caller makes an invalid state change, we shouldn't allow the
status to be updated, for instance from DISCONNECTED to CONNECTED if
success and failure race with each other and failure wins, as seen in
fd.o #37078; we should just emit the critical warning and leave it
DISCONNECTED.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.