[Bug 34796] Implement ContactInfo

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34796

--- Comment #69 from Debarshi Ray <debarshi.ray at gmail.com> 2011-05-11 11:08:58 PDT ---
(In reply to comment #68)
> Review of attachment 46610 [details]:
> 
> ::: src/idle-contact-info.c
> @@ +63,3 @@
> +{
> +    return (c == '#') || (c == '!') || (c == '&') || (c == '+');
> +}
> 
> Why not turn this code into a function in muc-channel, like _is_modechar(),
> and call it from the two places?

Done.

> @@ +304,3 @@
>      for (i = 0; channelsv[i] != NULL; i++) {
> +        const gchar *channel = channelsv[i];
> +        const gchar *field_params[2] = {NULL, NULL};
> 
> This shouldn't be const. You shouldn't have to cast the const away at the end
> of the block when you free the string. I think you can past a char *[] to a
> function expecting const char * const *?

Since we can't assign char ** to const char **, lets use a char ** and use the
cast while passing the value to the function.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.