[Bug 33271] Implement ChannelDispatcher.DelegateChannels() and PresentChannel()

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri May 13 17:50:46 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=33271

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |PLUS PLUS PLUS

--- Comment #9 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-05-13 08:50:46 PDT ---
(In reply to comment #8)
> http://cgit.collabora.co.uk/git/user/cassidy/telepathy-mission-control/log/?id=refs/heads/re-dispatch-33271
> now implements new new version of the spec (bug #37109)

Did you mean to include the doc/reference/*/tmpl/*.sgml files?

+static ChannelToDelegate *
+channel_to_delegate_new (DelegateChannelsCtx *ctx,
+  McdAccount *account,
+  McdChannel *channel)

then

+static void
+free_not_delegated_error (gpointer data)
+{
+    g_boxed_free (TP_STRUCT_TYPE_NOT_DELEGATED_ERROR, data);
+}

What's up with the indentation?

Okay, everything else looks fine. In an ideal world I'd like another test or
two for multiple channels which one fails and one succeeds in delegation and
stuff like that, but if you cba... :-)

Merge away, once the spec branch is merged.

Oh, also, could you give me spec branch which adds a comment to
DelegateChannels and PresentChannels saying which version of MC this was
released in?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list