[Bug 35341] Use Connection.Interface.ContactBlocking in Tp::ContactManager

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35341

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |review+ after a small
                   |                            |change

--- Comment #18 from Olli Salli <ollisal at gmail.com> 2011-05-15 10:20:22 PDT ---
Still in void ContactManager::Roster::onContactListNewContactsConstructed:

        if (!cachedAllKnownContacts.contains(contact)) {
            warning() << "Contact" << contact->id() << "removed from
ContactList but not cached, "
                "ignoring.";
            continue;
        }

For clarity, now that we have the separate contactListContacts set, shouldn't
we change the above to check that set instead (as that's what should be in sync
with the service's list)? The warning message could be turned to a more
descriptive one accordingly, like "removed from contact list, but wasn't
present".

This won't have a difference unless there is a change signal with the same
contact in both added and removed sets, but would be cleaner and also have
better performance (for contacts which are still blocked, so still in all
known) for filtering out redundant contact removals emitted by services (like
Gabble seems to be doing in bug 35352).

Do you have Telepathy commit access? If yes, please merge after the above
change, otherwise ping me and I'll merge for you.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.