[Bug 37283] Don't leave "away" when the shared status is remotely changed

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37283

--- Comment #4 from Marco Barisione <marco.barisione at collabora.co.uk> 2011-05-17 07:03:09 PDT ---
(In reply to comment #2)
> The code looks fine, as does the behaviour change; I have a couple of nitpicks
> on the test. Thinking about it, the complexity here is because we don't have a
> concept of shared status in the Telepathy API, so we're trying to squish two
> concepts into one. :)

Yep.

> +    list_attrs['status'] = list_attrs.get('status') or msg
> 
> I think this means the same as list_attrs.get('status', msg) which I find
> clearer.

Erm... yes. I copied that code from the other test. In theory the 2 things are
different, but in this case they mean the same.

> Hmm, I wonder if we could have test API like this:
> [...]
> and then we could use:
> 
>     with ForbiddenDBusEvents(q, EventPattern(...), ...):
>         do some testing

Nope, we cannot use "with" with our minimum requirement for Python.

> +    # Test that status doesn't change when we are away and the status is
> +    # changed from another client.
>
> I think maybe this deserves a little more explanation of what's being tested:
> specifically, “Test that our own status as exposed over D-Bus doesn't change
> when we are away and other clients change the shared status”, maybe?

Sure.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.