[Bug 35886] Add support for text edits

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=35886

--- Comment #2 from David Laban <david.laban at collabora.co.uk> 2011-05-17 17:31:38 PDT ---
(In reply to comment #1)
> After having a ref-counting crisis and talking with wjt for a while, I think I
> have a minimal API:
> 
> supported use case is:
> monday: message a
> tuesday: message b supersedes a
> wednesday: message c supersedes b
> 
> LogStore.get_events(monday) -> [c, b, a] (even though c happened on Wed) a
> naive log viewer implementation should not lose the information that a was
> edited.
-- Actually, sjoerd suggested that LogStore.get_events(monday) should only
return
c, and dup_supersedes() can be used to get more information. This means that a
naive log viewer presents the user with messages as they are semantically
intended.

> The following representation is less trivial to implement (will file a bug and
> do it later) but is representable by the api.
> message a
> message b supersedes a
> message c supersedes a
> 
> c.dup_supersedes() -> [a, b]
-- Actually, I just fixed that.

> Currently, It doesn't properly link events that happen on different days
> (requires some refactoring to make it easier to store events in random bullshit
> places and deciding how to write a test for it), but it should be usable as a
> base for CM/UI writers to test against if you avoid that bug.
-- This is still outstanding.

Please review:
http://cgit.freedesktop.org/~alsuren/telepathy-logger/log/?h=edits-35886. I
will fix the editing events from yesterday issue as a separate issue.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.