[Bug 36334] high-level interface for Conn.I.Balance

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=36334

--- Comment #6 from Emilio Pozuelo Monfort <pochu27 at gmail.com> 2011-05-19 03:15:34 PDT ---
(In reply to comment #5)
> -      goto finally;
> +      g_simple_async_result_set_from_error (result, in_error);
>      }
> 
> Immediately noticed you've removed the goto finally; here. You don't want to do
> this because @props will be NULL.

Right, amended (added a return; ).

I wonder if we need the g_object_freeze_notify() / g_object_thaw_notify()
around tp_connection_unpack_balance(), given that
tp_connection_unpack_balance() calls them itself. Is that so
notify::balance-uri is emitted together with the other notify signals? Is it a
problem if they aren't? If so, we could avoid that by adding an optional const
gchar *balance_uri parameter to tp_connection_unpack_balance(). That would keep
the code somewhat cleaner IMHO.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.