[Bug 33460] IM and MUC channels should use wocky_porter_send_async(), and emit failing delivery reports

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33460

--- Comment #10 from Siraj Razick <siraj.razick at collabora.co.uk> 2011-05-23 05:13:20 PDT ---
(In reply to comment #9)
> Functionally, this looks fine. Some coding style points:
> 
> > +void
> > +gabble_message_util_add_chat_state (LmMessage *msg,TpChannelChatState state);
> 
> Space after comma.
> 
> It'd be nice to say WockyStanza * rather than LmMessage * (the latter is just a
> backwards-compat alias for the former) in new/modified code like this.
> 
> Conventional indentation for a declaration (see
> http://telepathy.freedesktop.org/wiki/Style examples 3 and 4, and note the
> difference) would be:
> 
> void gabble_message_util_add_chat_state (WockyStanza *msg,
>     TpChannelChatState state);
> 
> > +WockyStanza *
> > +gabble_message_util_build_stanza (TpMessage *message,
> > + GabbleConnection *conn, LmMessageSubType subtype, TpChannelChatState state,
> > + const char *recipient, gboolean send_nick, gchar **token, GError **error);
> 
> For the same reasons I'd prefer that to look more like this:
> 
> WockyStanza *gabble_message_util_build_stanza (TpMessage *message,
>     GabbleConnection *conn, WockyStanzaSubType subtype,
>     TpChannelChatState state, const char *recipient, gboolean send_nick,
>     gchar **token, GError **error);

ok thanks :).. I just updated my second commit with those style changes.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.