[Bug 37360] TpChannel: high level API for Password

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 25 11:21:55 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=37360

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-05-25 02:21:55 PDT ---
(In reply to comment #1)
> /**
>  * TpChannel:password-needed:
>  *
>  * If %TRUE, tp_channel_password_provide_password_async() has to be called
>  * to be able to join the channel.
>  *
>  * This is not guaranteed to be meaningful until tp_proxy_prepare_async() has
>  * finished preparing %TP_CHANNEL_FEATURE_PASSWORD; until then, it may return
>  * %FALSE even if the channel is actually protected by a password.
>  */

For completeness, presumably this emits notify::password-needed when
appropriate? (If so, it's worth mentioning that in the docstring.)

> Maybe the provide async call should fail with TP_ERROR_AUTHENTICATION_FAILED if
> the password is not correct?

I like this better than the "out" boolean. I'm not sure why we didn't do this
in the D-Bus API...

(Looking at the D-Bus API again, I'm also not sure why ProvidePassword claims
to be able to raise InvalidArgument.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list