[Bug 28015] TpChannelDispatchOperation: convenience API to Claim and reject CDOs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28015

--- Comment #7 from Will Thompson <will.thompson at collabora.co.uk> 2011-05-25 10:02:57 PDT ---
Review of attachment 47118:
 --> (https://bugs.freedesktop.org/review?bug=28015&attachment=47118)

::: telepathy-glib/channel-dispatch-operation.c
@@ +1606,3 @@
+      TpChannel *channel = g_ptr_array_index (self->priv->channels, i);
+
+      g_error_free (error);

If the callback were to use its user_data, it would be unsafe because 'self'
might have died before the callback got called.

But it doesn't, so you should pass NULL.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.