[Bug 28015] TpChannelDispatchOperation: convenience API to Claim and reject CDOs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28015

--- Comment #17 from Will Thompson <will.thompson at collabora.co.uk> 2011-05-30 05:34:01 PDT ---
Review of attachment 47311:
 --> (https://bugs.freedesktop.org/review?bug=28015&attachment=47311)

::: telepathy-glib/channel.c
@@ +2402,3 @@
+        }
+
+  if (error != NULL)

I think there's way too much debugging output in this function. And a goto! I'd
just DEBUG() if Destroy() fails, move the “Close(); return;” into
get_invalidated() == NULL {}, and then you can lose the goto.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.