[Bug 37748] New: Tp::ContactManager::lookupContactByHandle is public

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37748

           Summary: Tp::ContactManager::lookupContactByHandle is public
           Product: Telepathy
           Version: git master
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-qt4
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: ollisal at gmail.com
         QAContact: telepathy-bugs at lists.freedesktop.org


Since 2009:

commit 2fd8c3cfdb1bc9cca2221ae7575e06c12038f3db
Author: Andre Moreira Magalhaes (andrunko) <andre.magalhaes at collabora.co.uk>
Date:   Wed Mar 11 02:43:40 2009 -0300

    ContactManager: Export lookupContactByHandle.

:o

This steers people to try and use it to get contact objects instead of
correctly building them asynchronously using contactsFor{Identifiers,Handles}.
There's even incorrect internal usage like that!

        // let's try to get the actor contact from contact manager if available
        groupSelfContactRemoveInfo = GroupMemberChangeDetails(
                connection->contactManager()->lookupContactByHandle(
                    qdbus_cast<uint>(details.value(QLatin1String("actor")))),
                details);

We'll have to deprecate it and then fix anybody who was (incorrectly) using it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.