[Bug 37145] Replace low level network code with GIO

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37145

--- Comment #5 from Sjoerd Simons <sjoerd at luon.net> 2011-05-30 07:50:22 PDT ---
My first pass, sorry, they're verry rough...

* 49871d7df27a8fa3964b87fe39831d9652431eda, looks good

* _socket_source_data_destroy -> doesn't free the cancellable ?

* g_idle_add(_object_destroy_idle, priv->cancellable); 
  destroying in an idle that seems suspicious?

* At dispose time all your outstanding operation really should have finished

* g_idle_add(io_err_cleanup_func, conn); idle destroys again ?

*  _socket_received -> Why ? why not just call _read_async?

* connect_to_host, leaks &error (and worse, ignores it) on error conditions

* Why using GSockets sources by hand ? Don't, instead use the async read
    functions.

* Things we lost: Setting SO_KEEPALIVE, Setting TCP_NODELAY

=> disconnect, cancel and then closing the connection ?
  -> Not Reporting an error on disconnect ?

* iface_send_impl is using a blocking write. it shouldn't.. :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.