[Bug 37034] Telepathy-Qt4 doesn't set the URI property for file transfers.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37034

--- Comment #13 from Olli Salli <ollisal at gmail.com> 2011-05-30 09:03:07 PDT ---
Reeview,

> Do not use bool variables to remember if FileTransferChannelCreationProperties > has properties

++

> Support the URI property in FileTransferChannelCreationProperties

Looks good now!

> Add constructor that sets properties from path to a local file to
> FileTransferChannelCreationProperties

Ditto!

> Add documentation for class FileTransferChannelCreationProperties

The docs look spot on now.

    98        parent->connect(fileTransferInterface,
99                SIGNAL(URIDefined(QString)),
100                SLOT(onUriDefined(QString)));

There still is this connection to a non-existent slot (unless you are actually
a IncomingFileTransferChannel) in the FileTransferChannel baseclass, and the
onUriChanged slot which is not used anywhere. Please re-read my previous
comment on the subject, adjusting this to only connect to the D-Bus signal in
IFTC, and use some backdoor (such as a protected slot) in the parent object to
set the parent's property to the value defined.

Actually it seems you missed my comments in comment 9 in general.

Waiting for the comment 9 changes and the unit tests.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.