[Bug 41455] Installing unit tests

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Nov 1 17:04:36 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=41455

--- Comment #5 from Alban Crequy <alban.crequy at collabora.co.uk> 2011-11-01 09:04:36 PDT ---
(In reply to comment #4)
> Actually:
> 
> 
> +  gchar *command_installed[] = {
> +      g_strdup_printf ("%s/%s",
> +          libexec,
> 
> libexec is potentially NULL. I think printf-style functions on some platforms
> are not NULL-safe.
(...)
> 
> This code duplication is a bit ugly. You could rework it to make it more
> readable, for instance by having command[0] assigned based on abs_top_builddir.


fixed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list