[Bug 42653] More properties for RoomConfig

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42653

--- Comment #8 from Will Thompson <will.thompson at collabora.co.uk> 2011-11-07 01:41:29 PST ---
Comment on attachment 53231
  --> https://bugs.freedesktop.org/attachment.cgi?id=53231
New iface: Channel.Interface.Picture

Review of attachment 53231:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=42653&attachment=53231)
-----------------------------------------------------------------

Looks good, broadly speaking.

::: spec/Channel_Interface_Picture.xml
@@ +1,5 @@
> +<?xml version="1.0" ?>
> +<node name="/Channel_Interface_Picture"
> +  xmlns:tp="http://telepathy.freedesktop.org/wiki/DbusSpec#extensions-v0">
> +
> +  <tp:copyright>Copyright © 2010–2011 Collabora Ltd.</tp:copyright>

I wonder why this is mojibaked in my browser. Is Splinter insufficiently UTF-8
clean? :/

@@ +73,5 @@
> +      </tp:possible-errors>
> +    </method>
> +
> +    <property name="Picture" tp:name-for-bindings="Picture"
> +              type="(ays)" tp:type="Avatar" access="read">

Do we maybe want to annotate this with EmitsChangedSignal: invalidates?

@@ +75,5 @@
> +
> +    <property name="Picture" tp:name-for-bindings="Picture"
> +              type="(ays)" tp:type="Avatar" access="read">
> +      <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> +        <p>The picture representing this channel.</p>

This property doesn't define what “no picture” looks like (though it's pretty
obvious, I guess). The Account.I.Avatar.Avatar property does; maybe move that
definition to the struct definition and then we're done?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.