[Bug 41417] Support Facebook's own-message extension

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41417

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-11-07 03:17:08 PST ---
(In reply to comment #3)
> Only two comments for your most recent patch:
> 
> Firefox is ruining my indentation pasting, but this block should be indented
> and have curly brackets:
> 
> + if (!tp_strdiff (stream_server, "chat.facebook.com"))
> + wocky_porter_register_handler_from (

Fair.

If bug 39057 is fixed I can replace this with
wocky_porter_register_handler_from_server() in any case I guess and remove the
conditional.

> The Facebook own-message test seems to rely on Gabble acking the IQ *before*
> signalling MessageReceived? Is that right?

No, the 'stream-' and 'dbus-' queues are independent these days.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.