[Bug 39188] TpFileTransferChannel: add API to send and receive the file

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 9 19:20:07 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=39188

--- Comment #6 from Will Thompson <will.thompson at collabora.co.uk> 2011-11-09 10:20:07 PST ---
+static void
+operation_failed (TpFileTransferChannel *self,
+    const GError *error)
+{
+  g_simple_async_result_set_from_error (self->priv->result, error);
+
+  g_simple_async_result_complete (self->priv->result);
+  tp_clear_object (&self->priv->result);
+}

The stray newline here offends me.

 static void
+tp_file_transfer_channel_uri_defined_cb (TpChannel *proxy,
+    const gchar *uri,
+    gpointer user_data,
+    GObject *weak_object)
+{
+  TpFileTransferChannel *self = (TpFileTransferChannel *) proxy;
+
+  self->priv->file = g_file_new_for_uri (uri);
+  g_object_notify (G_OBJECT (self), "file");
+}

If the CM erroneously emits this signal when URI was already defined, this
leaks.

(Sorry this keeps coming in in dribs and drabs; I'll say as much when it's
finished.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list