[Bug 41790] Make libnice dependency optional

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41790

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-11-10 07:35:54 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > +    AC_SUBST(NICE_CFLAGS)
> > +    AC_SUBST(NICE_LIBS)
> > +else
> > +    NICE_CFLAGS=
> > +    NICE_LIBS=
> > +fi
> > 
> > If you're not AC_SUBSTing the empty variables, can't you just leave the else
> > clause out entirely?
> Actually I should AC_SUBST them every time, will fix this
> 
> > I don't really like how this patch litters quite so many ifdefs around, even
> > down to changing the number of arguments to gabble_file_transfer_channel_new()…
> Tbh, I don't like it either, but I don't see how it could be any better,
> suggestions?

I guess it would be clearer if there were something like a subclass of
GabbleFTChannel for GTalk (well, maybe GabbleFTChannel would be an abstract
base class and there would be two subclasses, one for GTalk and one for SI
transfers), maybe?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.