[Bug 28366] Add DBusTube interface support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28366

--- Comment #21 from Olli Salli <ollisal at gmail.com> 2011-11-10 11:42:52 PST ---
(In reply to comment #19)
> The lcov report has been attached, and it shows test
> coverage is almost 100% (and covers all of the functions we're interested in).

Well, AFAICS it ranges from 73.3% for OutgoingDBusTubeChannel to 90.6% for
PendingDBusTubeConnection. Let's say it's manageable - the rest being corner
case early outs. Which would be easy enough to test, though - so please green
them as well in ODTC and DTC, to get the total coverage up. I mean the
early-outs for "you requested credentials checking but it's not supported",
"you used a feature without preparing it" and the like.

Something even more important to test would be the rather non-trivial contact
build code for the DBusNames. That's currently not tested in DTC.

Btw, on the subject of credential checking - did you verify that it makes sense
for the API user to decide whether the SCM_CREDS message should be required?
The potential forces which might make this nonsense are:
1) dbus unix socket transport might always require the message on platforms
where it is supported(!!) - or is it gabble which gets to decide whether it
requires it or not?
2) in turn, many (all?) transport libraries in the CONNECTING side might offer
no way to force or prevent passing it - so then the API user's decision would
become "OK I'll find out what my dbus transport library does in its internals,
for the platforms I want to support". It's distinctly better if WE figure this
out in behalf of the users, being in a much better position expertise wise to
do that.

Here's a few things to consider for now. I'll post a full review of the current
state of the APIs and implementation tomorrow.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.