[Bug 39188] TpFileTransferChannel: add API to send and receive the file

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39188

--- Comment #13 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-11-11 03:04:34 PST ---
(In reply to comment #12)
> + * <informalexample><programlisting>GHashTable *request = tp_asv_new (
> 
> Do you know about the |[ ... ]| shortcut for <informalexample><programlisting>
> ... <//>?

No? I tried replacing them and it didn't work and can't find an example of them
in use in tp-glib already?

> + * Once a #TpFileTransferChannel is created as a proxy to the channel
> + * on D-Bus, the "notify::state" GObject signal should be monitored
> + * and when at %TP_FILE_TRANSFER_STATE_ACCEPTED
>   * tp_file_transfer_channel_provide_file_async() should be called.
> 
> I don't think this flows very well. “The "notify::state" GObject signals on the
> resulting channel should be monitored; when the channel moves to state 
> %TP_FILE_TRANSFER_STATE_ACCEPTED, tp_file_transfer_channel_provide_file_async()
> should be called.” maybe?

OK.

> +   * <informalexample><programlisting>tp_base_client_take_handler_filter
> (handler, tp_asv_new (
> +   *               TP_PROP_CHANNEL_CHANNEL_TYPE, G_TYPE_STRING,
> TP_IFACE_CHANNEL_TYPE_FILE_TRANSFER,
> +   *               TP_PROP_CHANNEL_TARGET_HANDLE_TYPE, G_TYPE_UINT,
> TP_HANDLE_TYPE_CONTACT,
> +   *                TP_PROP_CHANNEL_REQUESTED, G_TYPE_BOOLEAN, FALSE,
> +   *              
> TP_PROP_CHANNEL_INTERFACE_FILE_TRANSFER_METADATA_SERVICE_NAME, G_TYPE_STRING,
> "service.name",
> +   *               NULL));
> +   * </programlisting></informalexample>
> 
> REQUESTED has an extra space of indentation.

Fixed.

> I forgot to say before: I think the documentation for
> TpFileTransferChannel:metadata should say what type its keys and values have,
> like the getter does.

Is the gtk-doc type string not enough?

      "metadata"                 GHashTable_gchararray+GStrv_*  : Read

> I've just noticed that lots of the gtk-doc comments for the various new
> properties don't have colons at the end of their names:

Yeah I saw that and forgot to add another commit adding them, but also didn't
think it was such a big deal as the original properties don't have them either.

>   /**
>    * TpFileTransferChannel:date
> 
> I wonder if they work regardless?

Yeaaahhh they do. I'll fix it anyway.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.