[Bug 42446] Allow building tp-gabble in Android

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=42446

--- Comment #9 from Will Thompson <will.thompson at collabora.co.uk> 2011-11-11 10:07:38 PST ---
Comment on attachment 53415
  --> https://bugs.freedesktop.org/attachment.cgi?id=53415
Support for Android patch

Review of attachment 53415:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=42446&attachment=53415)
-----------------------------------------------------------------

::: autogen.sh
@@ +32,5 @@
> +    # Fetch submodules if needed
> +    if test ! -f lib/ext/wocky/autogen.sh -o ! -f lib/ext/telepathy-yell/autogen.sh;
> +    then
> +    echo "+ Setting up submodules"
> +    git submodule init

This should be indented.

::: configure.ac
@@ +329,5 @@
>  ac_configure_args=$prev_ac_configure_args
>  
> +dnl Check if Android build
> +AC_ARG_ENABLE(submodules,
> +              AS_HELP_STRING([--disable-submodules],[compile Android code]),

The description is still wrong! I suggested wording in my last review…

::: src/Makefile.am
@@ +286,5 @@
> +	 -:CFLAGS $(DEFS) $(CFLAGS) $(DEFAULT_INCLUDES) $(INCLUDES) \
> +	  $(AM_CFLAGS) -DBUILD_AS_ANDROID_SERVICE \
> +	  -:CPPFLAGS $(CPPFLAGS) $(AM_CPPFLAGS) $(telepathy_gabble_LDFLAGS) \
> +	  -:LDFLAGS $(telepathy_gabble_LDADD) $(libgabble_convenience_la_LIBADD) -lgio-2.0 -ldbus-1 \
> +	  -lsoup -lgabble_ext -lnice -lgcrypt -lgnutls -lxml2 -lsqlite3 \

My point about this—“Simon's point about this—“It would be much better if we
could avoid hard-coding
these.”—hasn't been addressed.”—hasn't been addressed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.