[Bug 42814] Migrate Butterfly accounts

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Nov 14 13:39:58 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=42814

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2011-11-14 04:39:58 PST ---
(In reply to comment #1)
> Here we go
> http://cgit.collabora.com/git/user/cassidy/telepathy-mission-control/log/?h=butterfly-migration-42814

     release_load_accounts_lock (lad);
+
+    migrate_accounts (account_manager);

I think you want to take an account lock for each account being migrated, and
release each one when the migration succeeds or fails; and call
migrate_accounts() before this call to release_load_accounts_lock().

account_lock is used to stop the account manager appearing on the bus until all
the accounts are loaded up and ready to go. Presumably we want the migration to
happen before MC appears on the bus? (With this branch at present, that's not
the case.)

It would be nice to annotate the new accounts with some indicator of the
account path they replace.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list