[Bug 32691] Support addressing in TpBaseProtocol

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32691

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-11-14 04:59:30 PST ---
Patches with substantial changes from you shouldn't really be --author=Eitan
any more, IMO. Attribute such patches to yourself, with "Based on a patch from
Eitan Isaacson <...>" in the commit message?

> Undraft Protocol.Interface.Addressing.

Not really valid, but will go away when this branch is rebased onto a version
of tp-glib with a version of tp-spec where P.I.A is undrafted.

> Make Protocol.Interface.Addressing functionality a GInterface.

I'd have vaguely preferred this one squashed into the previous commits - you'd
have to split it, since half of it is squashed into "add the feature" and the
other half into "... and add a test".

Review in detail in a moment (I'll review a squashed version rather than using
gitweb).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.