[Bug 39188] TpFileTransferChannel: add API to send and receive the file

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39188

Xavier Claessens <xclaesse at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #19 from Xavier Claessens <xclaesse at gmail.com> 2011-11-15 04:20:27 PST ---
There is a use-case not covered by this:

For incoming file transfers, the approver could display a "save as" button and
set the URI property, then give to handler. In that case handler does not have
to give a GFile in accept_file_async() and we need an API for the approver to
set the URI but not start the transfer.

I suggest to add something like this in the beginning of accept_file_async():

  if (file != NULL && self->priv->file != NULL)
    g_return_if_fail (g_file_equal (file, self->priv->file));
  if (file == NULL)
    file = self->priv->file;

And file_replace_async_cb() should be modified to not set URI if we are using
the URI already set.

We probably also need a convenient _set_uri_async() method that approver can
call.

So IMO the merged code is already a good step forward, but I'm reopening to
keep track of this last use-case to handle.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.