[Bug 41789] Expose Facebook ids into Facebook Chat contacts’

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41789

--- Comment #9 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-11-17 08:45:24 PST ---
(In reply to comment #8)
> > addressing-util: Refactor gabble_parse_vcard_address in
> > gabble_normalize_vcard_address, gabble_vcard_address_to_jid
> > and gabble_jid_to_vcard_address.
> 
> Er, this isn't (just) refactoring... it's also "... and make x-facebook-id
> parsing expect a number, not a JID". Please be a bit more careful with your
> commit messages - they're all the context you'll have in n years' time when
> you're debugging this stuff and have forgotten how it worked :-)
Amended the commit with a better msg :)

> > + while (*s && (g_ascii_isalnum (*s))) s++;
> 
> That's not "is numeric" :-)
Haha, I swear I misread isnum there, changed to isdigit now :P

> (also, our coding style would have you use two lines for that)
Done also.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.