[Bug 30296] Add Conn.I.Addressing support to Gabble

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30296

--- Comment #23 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-11-21 07:43:18 PST ---
(In reply to comment #22)
> (In reply to comment #21)
> > > I can't help feeling that gabble_parse_xmpp_uri() should validate the node,
> > > domain and resource individually
> > Indeed. Let's open a bug for this. Want some comments in the code?
> 
> Yes please, with the bug number.
bug #43140

> > + normalized_uri = proto.Addressing.NormalizeURI(
> > + "xmpp:EITAN?@example.COM/resourc?e")
> > +
> > + assertEquals("xmpp:eitan%3F at example.com", normalized_uri)
> 
> I'm not really sure whether this should normalize to this, or to
> "xmpp:eitan%3F at example.com/resourc%3Fe". Ignoring the resource is certainly
> good enough for now, but the resource is sometimes significant (for chatroom
> members, mainly).
> 
> It comes down to what we want "NormalizeURI" to mean, I think. Possibilities:
> 
> 1) here is a contact, please discard unnecessary cruft and reduce it to the
>    minimal information necessary to identify this contact
> 
>    (this should discard the resource, a query-string if any, etc.)
> 
> 2) normalize this URI without changing its meaning
> 
>    (this should not discard the resource or query-string)
> 
> I wonder whether the method should have been called NormalizeContactURI if what
> we want is (1)?
We opted for renaming NormalizeURI to NormalizeContactURI and implement #1.

> Oh, another bug to be filed for later: normalizing verb-like URIs
> (xmpp:smcv at example.com?message;body=Hello%20World) doesn't currently do
> anything sensible. At a minimum, we should truncate at "?" (assuming
> interpretation 1).
And that would be bug #43142

Branch updated with latest changes in Proto.I.Addr support. It will be in the
next gabble release.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.