[Bug 43222] Add Qt5 support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43222

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #7 from Olli Salli <ollisal at gmail.com> 2011-11-25 03:08:51 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > + * method will always fail unless QHostAddress::Any (also
> > QHostAddress::AnyIPv4 if using Qt5) or
> > 
> > "or AnyIPv4 in Qt5"
> Done

Still:

- * Returning the pair (QHostAddress::Any, 0) (also the pair
(QHostAddress::AnyIPv4, 0) if using Qt5)
+ * Returning the pair (QHostAddress::Any, 0) (or also the pair
(QHostAddress::AnyIPv4, 0) in Qt5)

"(or alternatively (QHostAddress::AnyIPv4, 0) in Qt5)" would be cleaner

> 
> > > QtDBus >= ${QT_MAX_VERSION}, QtDBus < ${QT_MIN_VERSION}
> > 
> > Doesn't look like that would be satisfiable very easily :)
> Done

Yes

> > Andre's currently working on this. We hit a Qt5 bug in the process... fun
> > times.
> Disabled tubes tests in this branch until Qt5 bugs are fixed.

+    # FIXME - Re-enable tube tests once Qt5 QHostAddress bugs are fixed

Please file an actual Qt bug report at https://bugreports.qt.nokia.com/ with
the concrete usecases for QHostAddress which are failing, and mention the
resulting ID in this CMakeLists.txt comment. And also file a fd.o bug against
tp-qt4 to re-enable the test once Qt is fixed, and add the URL to the Qt bug
there (sadly a different bug tracker though).

Otherwise the Qt issue has no chance of getting fixed. And we don't remember to
reintroduce the test even when it gets fixed.

We could also add this to a "known issues" section of NEWS of releases until
the bug gets fixed in Qt5, so people don't file bug against tp-qt4 because that
specific thing doesn't work because of Qt upstream bugs.

The rest looks good now. So provided you now double-check that all combinations
of finding Qt4 or Qt5 and the user specifying Qt4/Qt5 build OR autodetect try
to produce the right kind of library, pkgconfig file and header installation
paths, please merge.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.