[Bug 41655] Move KeyFile and possibly ManagerFile out of our public API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41655

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ollisal at gmail.com

--- Comment #2 from Olli Salli <ollisal at gmail.com> 2011-11-25 03:35:51 PST ---
(In reply to comment #1)
> Branch at URL attempts to fix this. 
> 
> Note that I did not "unexported"(TP_QT_NO_EXPORT) the classes as doing it would
> break the tests. Should we build key-file/manager-file.cpp in the tests itself?

Build as part of the test binaries, without putting to a library in between?
Yeah, that'd work I believe. We could actually do the same for TestBackdoors
and remove it from tp-qt4 sources completely (unless it links to non-exported,
rather than merely protected, but exported, tp-qt4 internal symbols - whether
it does that, I can't remember).

You could also have a static library consisting of KeyFile, ManagerFile and
TestBackdoors and link that into the relevant tests.

But anyway, just not installing headers for them accomplishes the main goal -
to remove them from the API and ABI we support. Even if we still had it in the
library private ABI, like TestBackdoors. But please experiment with your idea
to see if we could remove them from there too - this would lead to slightly
less symbols in the lib, so faster symbol lookup in runtime linking.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.