[Bug 43222] Add Qt5 support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43222

--- Comment #9 from Andre Moreira Magalhaes <andrunko at gmail.com> 2011-11-25 06:49:49 PST ---
(In reply to comment #7)
> Still:
> 
> - * Returning the pair (QHostAddress::Any, 0) (also the pair
> (QHostAddress::AnyIPv4, 0) if using Qt5)
> + * Returning the pair (QHostAddress::Any, 0) (or also the pair
> (QHostAddress::AnyIPv4, 0) in Qt5)
> 
> "(or alternatively (QHostAddress::AnyIPv4, 0) in Qt5)" would be cleaner
Done

> 
> > > Andre's currently working on this. We hit a Qt5 bug in the process... fun
> > > times.
> > Disabled tubes tests in this branch until Qt5 bugs are fixed.
> 
> +    # FIXME - Re-enable tube tests once Qt5 QHostAddress bugs are fixed
> 
> Please file an actual Qt bug report at https://bugreports.qt.nokia.com/ with
> the concrete usecases for QHostAddress which are failing, and mention the
> resulting ID in this CMakeLists.txt comment. And also file a fd.o bug against
> tp-qt4 to re-enable the test once Qt is fixed, and add the URL to the Qt bug
> there (sadly a different bug tracker though).
> 
> Otherwise the Qt issue has no chance of getting fixed. And we don't remember to
> reintroduce the test even when it gets fixed.
> 
> We could also add this to a "known issues" section of NEWS of releases until
> the bug gets fixed in Qt5, so people don't file bug against tp-qt4 because that
> specific thing doesn't work because of Qt upstream bugs.
Qt bugs:
https://bugreports.qt.nokia.com/browse/QTBUG-22898 and
https://bugreports.qt.nokia.com/browse/QTBUG-22899

tp-qt bug:
https://bugs.freedesktop.org/show_bug.cgi?id=43243

> The rest looks good now. So provided you now double-check that all combinations
> of finding Qt4 or Qt5 and the user specifying Qt4/Qt5 build OR autodetect try
> to produce the right kind of library, pkgconfig file and header installation
> paths, please merge.
I did, but if someone else with another Qt5 setup could double check I'd
appreciate.

And tnx for the reviews.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.