[Bug 41388] Should not assume password auth is supported

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Oct 3 11:46:15 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=41388

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2011-10-03 02:46:15 PDT ---
I don't like the name of the method: it's singular, but the argument is plural.

How about wocky_auth_registry_supports_one_of()? (Which I don't like much
either.)

And can we have a gtk-doc comment?

And the method implementation is wrong. I can see other password-based
authentication mechanisms that Wocky supports; SCRAM-SHA-1, for starters. I
think you probably want to be using some of the logic from
wocky_auth_registry_select_handler() and/or
wocky_auth_registry_start_auth_async_func().

Can you describe in the Gabble commit message why this is needed?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list