[Bug 31729] use TpBaseContactList in Salut

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31729

--- Comment #3 from Xavier Claessens <xclaesse at gmail.com> 2011-10-03 08:17:12 PDT ---
(In reply to comment #2)
> I'm not really keen on "priv->roster" as the name of the set of contacts: the
> roster is an XMPP construct that link-local XMPP explicitly doesn't use, and
> someone carefully avoided calling this object SalutRoster. priv->contacts?
> priv->nearby?

there is already manager->contacts, I'll just call it priv->handles, which is
what it is...

> > +static gboolean
> > +contact_manager_get_contact_list_persists (TpBaseContactList *self)
> > +{
> > + return FALSE;
> 
> You could use tp_base_contact_list_false_func instead of reimplementing it.

good, didn't see that one.

> > + base_connection = tp_base_contact_list_get_connection (
> > + (TpBaseContactList *) self, NULL);
> > + self->connection = SALUT_CONNECTION (base_connection);
> 
> Borrowed reference. Can you ref it, and release the ref on disconnection? (It
> might not be safe to do so - it isn't in Gabble, due to internal assumptions
> that it's safe to use the Roster right until the bitter end - in which case you
> should comment it instead.)

TpBaseContactList already keeps a strong ref until status goes to DISCONNECTED
if I understand correctly, so I could do the same in the subclass.

Note that this is not different with my patch, it is just that new the property
in in the base class instead of in SalutContactManager.

> > + /* Not really already received, but we cannot know when initial set
> > + * is fetched */
> 
> The Avahi backend, at least, ought to be able to signal received when Avahi
> says ALL_FOR_NOW?

I've no idea.

> > + /* No variant taking a GError*, really? */
> > + tp_base_contact_list_set_list_failed ((TpBaseContactList *) self,
> > + err->domain, err->code, err->message);
> 
> Add one to telepathy-glib taking a const GError * if you really want to, but I
> don't think this is really any harder to use.

doesn't matter tbh. removed the comment :)



Branch updated

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.