[Bug 37145] Replace low level network code with GIO

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37145

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #25 from Will Thompson <will.thompson at collabora.co.uk> 2011-10-03 10:43:26 PDT ---
Re “idletest: Split the data if it has multiple messages before parsing it”, I
think it will work, but… Looking at
<http://twistedmatrix.com/documents/10.0.0/api/twisted.words.protocols.irc.IRC.html#dataReceived>
and the method below it, I believe we could replace the test suite manually
splitting up lines and messages, by implementing handleCommand rather than
dataReceived.

Not a merge blocker though.

I'm not entirely sure that we need to re-queue messages if
idle_server_connection_send_finish() fails—surely that only happens if the
underlying socket connection dies, in which case the IRC session is over
anyway? (In the current Tp model, that is.) But the code doesn't look *wrong*,
so let's leave it.

Hooray!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.