[Bug 41654] New: Accessors in Channel and other D-Bus proxies which are initialized from immutable properties should return the immutable property data immediately after construction

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Oct 10 17:55:56 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=41654

           Summary: Accessors in Channel and other D-Bus proxies which are
                    initialized from immutable properties should return
                    the immutable property data immediately after
                    construction
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: tp-qt4
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: ollisal at gmail.com
         QAContact: telepathy-bugs at lists.freedesktop.org


Currently, Channel only populates the accessors like channelType() from the
immutable properties when FeatureCore preparing is started. This makes us and
others write code like the following in the handleChannels() implementation of
the internal SimpleStreamTubeHandler class:

> // TODO: if Channel ever starts utilizing its immutable props for the immutable
> // accessors, use Channel::channelType() here
> const QString channelType =
>     chan->immutableProperties()[QLatin1String(
>          TELEPATHY_INTERFACE_CHANNEL ".ChannelType")].toString();

I believe a similar situation exists for some other classes too. I specifically
fixed ChannelRequest to work sensibly in this regard last year.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list