[Bug 41448] Installing unit tests

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=41448

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-10-10 10:32:42 PDT ---
(In reply to comment #1)
> +  AC_DEFINE(ENABLE_TESTS_INSTALL, [],
> 
> Why not ENABLE_INSTALL_TESTS like the option name?

--enable-installed-tests, ENABLE_INSTALLED_TESTS would be better grammar, and
match what I did in dbus.

> +twistedcapstestsdir = $(GABBLE_TESTS_PATH)/twisted/caps
> 
> Are you sure there is no way to avoid having an entry per subdirectory? :(

The thing to search for is "nobase" in Automake documentation. If
nobase_dist_twisted_DATA contains "caps/foo.py" then it will be installed to
$(twisteddir)/caps/foo.py.

> +EXTRA_DIST = \
> +   $(TWISTED_TESTS) \
> +   $(TWISTED_OTHER_FILES) \
> 
> How was it working before without this?

A guess: if you have things in a variable whose name has the dist_ prefix,
they're always distributed, without needing to be in EXTRA_DIST. I personally
prefer appropriate use of dist_ prefixes, which means EXTRA_DIST basically
means "distributed but not installed".

> You should not rely on the python executable to be /usr/bin/python. I think
> that AM_PATH_PYTHON provides some magic to detect the python executable.

AM_PATH_PYTHON sets $(PYTHON). In Gabble only, $(TEST_PYTHON) is also relevant.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.